Add automatic resource cleanup #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
- Add ResourceTracker to manage k8s resources lifecycle - Add automatic cleanup on process termination - Add timeout mechanism for cleanup operations - Add tests for cleanup functionality - Update documentation with cleanup information
- Add workflow to run tests on PRs and master branch - Include race condition detection - Add code formatting check
- Add thread-safe client access - Fix race conditions in cleanup code - Improve test organization - Add more test coverage
- Fix boolean comparisons - Remove unnecessary fmt.Sprintf - Use fmt.Errorf instead of errors.New(fmt.Sprintf()) - Remove unused code and imports - Fix variable naming
- Update Go version to 1.21 - Add package comments to cmd package - Fix variable naming (CPU vs Cpu) - Fix signal handling (remove SIGKILL) - Fix error handling and boolean comparisons - Update deprecated code (io/ioutil, grpc.WithInsecure)
omrikiei
force-pushed
the
add-resource-cleanup
branch
from
fcf32f8 to
b3b5a11
Compare
- Replace sync.Once with proper mutex protection - Add thread-safe access to global variables - Add proper locking around client operations - Add proper locking around kubeconfig access - Add proper locking around verbose flag
omrikiei
force-pushed
the
add-resource-cleanup
branch
from
ebcef7b to
605c0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic resource cleanup functionality to address issue #134. Changes include:
The changes ensure that no orphaned resources are left in the cluster after unexpected shutdowns or crashes. The cleanup process is: